Autobuy in version 1.6.0

Cannon

Has any else had problems using the autobuy command with flhook plugin 1.6.0 - I think it is broken?

During the base docking process, items are automatically bought and added to the player’s ship but the player gets kicked when this happens. The “flserver-errors.log” file contains an entry like:

1: E:\FL\Scratch\Source\Server\gf\BaseDB.cpp(1645) : *** ERROR: Location 0 is invalid

Looking at the code, BaseEnter() calls HkPlayerAutoBuy() which calls HkAddCargo(). HkAddCargo() uses a base/location exit/enter trick to deal with the flserver cheat detection but the location isn’t valid when the BaseEnter function is called.

I tried the following modification in HkAddCargo() and it seemed to fix the problem…I’m not sure it does but it works for a few simple test cases I tried.

if(iBase) {
if(iLocation) // ADDED THIS CHECK
Server.LocationExit(iLocation,iClientID);
Server.BaseExit(iBase,iClientID);
if(!HkIsValidClientID(iClientID)) // got cheat kicked
return HKE_PLAYER_NOT_LOGGED_IN;
}

and

if(iBase) {
Server.BaseEnter(iBase, iClientID);
if(iLocation) // ADDED THIS CHECK
Server.LocationEnter(iLocation, iClientID);
}

w0dk4

thx!

not running the version on a live server myself surely has drawbacks

jase240

one timely fix there cannon awesome stuff, confirming it works.

tai

could someone apply that and recompile for us people not familiar with C++ ?

? Offline

ye found out it when you dock it buys everything even when its not sold on the base then you get a kick for cheating
but if you buypass it it means you can buy stuff from a base that dosent sell it
basicly no good

cheeseontoast

i believe this has been fixed in he latest version???

Cannon

Already done (an unofficial version): http://forge.the-starport.net/gf/download/user/106/89/flhook1.6.0_plugin-p3.7z
and it is also fixed the next release - which isn’t released yet.

tai

thank you guys