FLScanII

Huor

On whom i may forward questions or “bugs”? Dont want to use the open thread here.

Ah, forgot to mention that its a great tool and effort you already have put in! Thanks!

Crazy

http://forge.the-starport.net/projects/flscan2/issues/new would be worth a try.

Thaddeus

Nice work guys, caught some more errors with the new tool.

Getting some errors turning up in the log spew

[info] Parsing Ship-Folder
[error] An error happend while parsing. The scan can't continue. 'Unsupported'   at FLScanIE.Util_Functions.UtfFile..ctor(String filePath)
   at FLScanIE.Util_Functions.Util.ParseNickUTF(String flDataPath, String file, Section section, String nick, String utf, Boolean errorUtf)
   at FLScanIE.ShipChecks.ParseShipFolder()
   at FLScanIE.Checker.Parse(String flPath)

[info] Checking Ship-Folder
[error] An error happend while checking ships 'Value cannot be null.
Parameter name: source'   at System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value)
   at FLScanIE.EquipmentChecks.EquipExists(String nick)
   at FLScanIE.ShipChecks.CheckShip(String file, Section ship)
   at FLScanIE.ShipChecks.CheckShipFile(String file)
   at FLScanIE.ShipChecks.CheckShipFolder()

Any ideas? obviously an unsupported & null value in those files, but where?

also

[info] Checks Loadouts
[error] An error happend while checking loadouts 'Object reference not set to an instance of an object.'   at FLScanIE.LoadoutChecks.CheckLoadouts()
   at FLScanIE.Checker.RunCheck(CheckDelegate check, String name)

I guess a typo in the model name/directory. but where? thats a big file!

M1C

@Hour, use the url crazy posted or just drop them here

@Thaddueus
Thanks for reporting!
I’ll work on better error messages today or tomorrow.

The first message is an invalid utf file (it will show you which after the next update)
The 2nd is a bug in FLScanII
The 3rd is bug, too. Are the files you tried to scan public?

Huor

OK tried here, did register on the forge site - but havent any access. Guess it must be activated by an Admin.

So OK here i go. There are quite a few errors reported that are no errors at all:

[error][systems\CF20\CF20.ini:899:Object:ids_info] ID not found! 499981

```The ID 499981 is available and can be found there are others which are reported as well but are available too. I assume that a dll file which contains these entries is not parsed. Its not a vanilla file but its listed in the freelancer.ini

[error][equipment\goods.ini:3422:Good:hull] Ship hull not found serafina

[warning] ‘>’ not found at end of ids 65722

[warning] Duplicate ids 524289

[error] area_nomadsdk2.ini:22 ‘formation_by_class = fighters’: missing formation_by_class, formation_by_class=fighters ref=CF97.ini:571 ‘encounter = area_nomads, 19, 0.083000’

[error] An error happend while checking fonts ‘Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.’ bei FLScanIE.FontChecks.CheckFontFolder()
bei FLScanIE.Checker.RunCheck(CheckDelegate check, String name)


Thats for now. I will report more problems - there are dozen more ;(

ColdFire

Hi, I tried it too, and I’m having errors.
My mod certainly contain real errors, so I’ll try to report only execution errors or those I don’t understand :

[error] An error happend while parsing. The scan can't continue. 'La méthode ou l'opération n'est pas implémentée.'   à FLScanIE.EquipmentChecks.ParseGoodFile(String file, List`1& goodNicknames)
   à FLScanIE.EquipmentChecks.ParseEquipmentFolder()
   à FLScanIE.Checker.Parse(String flPath)
```(the method or operation is not implemented)

[error] An error happend while checking loadouts ‘La valeur ne peut pas être null.
Nom du paramètre : source’ à System.Linq.Enumerable.Contains[TSource](IEnumerable1 source, TSource value, IEqualityComparer1 comparer)
à System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value)
à FLScanIE.EquipmentChecks.EquipExists(String nick)
à FLScanIE.LoadoutChecks.CheckLoadoutFile(String file)
à FLScanIE.LoadoutChecks.CheckLoadouts()
à FLScanIE.Checker.RunCheck(CheckDelegate check, String name)

[error] An error happend while checking ships ‘La valeur ne peut pas être null.
Nom du paramètre : source’ à System.Linq.Enumerable.Contains[TSource](IEnumerable1 source, TSource value, IEqualityComparer1 comparer)
à System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value)
à FLScanIE.EquipmentChecks.EquipExists(String nick)
à FLScanIE.ShipChecks.CheckShip(String file, Section ship)
à FLScanIE.ShipChecks.CheckShipFile(String file)
à FLScanIE.ShipChecks.CheckShipFolder()
à FLScanIE.Checker.RunCheck(CheckDelegate check, String name)

[error] An error happend while checking equip ‘La référence d’objet n’est pas définie à une instance d’un objet.’ à FLScanIE.EquipmentChecks.CheckEquipmentFile(String file)
à FLScanIE.EquipmentChecks.CheckEquipmentFolder()
à FLScanIE.Checker.RunCheck(CheckDelegate check, String name)

[error] An error happend while checking fonts ‘La référence d’objet n’est pas définie à une instance d’un objet.’ à FLScanIE.FontChecks.CheckFontFolder()
à FLScanIE.Checker.RunCheck(CheckDelegate check, String name)


Other than that, the other errors I have seem to be real errors, or it tells me where to look for something strange.
The report is maybe a little difficult to understand for non-english and non-freelancer-gurus people (like me), but it's a very good work…

Thank you

Thaddeus

M1C wrote:
@Thaddueus
Thanks for reporting!
I’ll work on better error messages today or tomorrow.

The first message is an invalid utf file (it will show you which after the next update)
The 2nd is a bug in FLScanII
The 3rd is bug, too. Are the files you tried to scan public?

I’ll wait for the update then, thanks. Files are from my own mod, its not public ~yet~

rik_starkiller

Guys,

Excellent tool, thanks ver much. If I spot an bugs that aren’t already on this thread I’ll let you know, but reall impressed with it.

Cheers,
Rik

M1C

Hi people!

@everyone who is experiencing bugs, please try this version:
http://forge.the-starport.net/projects/flscan2/repository/entry/bin/FLScanII.exe
I improved the error-handling a lot and worked on better messages, most of your bugs were caused by two big bugs which are fixed now.

Thanks for reporting all the bugs!

@Huor:
Could you send me the dll which conains ID 499981?
I’m not familiar with the npc-stuff, sorry

@Thaddeus:
fixed

@ColdFire:
These where FLScanII-bugs, fixed.

Thaddeus

Thanks, its going great, the new version will give me another couple of days work, lol

original errors are gone but latest version caught this

[error] Could not parse utf file! Unsupported, file: C:\Program Files\Microsoft Games\Freelancer\data\ships\rheinland\rh_elite\rh_elite_dmg_starboard_engine.sur

thats a standard file, havent touched it myself. still has a 2002 timestamp so hasnt changed since install…

all the system files "LightSource"s seem to be picked up as well

[warning] Unexpected section Ambient in file Systems\Li01\Li01.ini
[warning] Unexpected section LightSource in file Systems\Li01\Li01.ini
[warning] Unexpected section LightSource in file Systems\Li01\Li01.ini
[warning] Unexpected section LightSource in file Systems\Li01\Li01.ini
[warning] Unexpected section LightSource in file Systems\Li01\Li01.ini

[warning][systems\Br04\Br04.ini:Background:228] Setting not found! basic_stars
[warning][systems\Br04\Br04.ini:Background:228] Setting not found! complex_stars

I also use Adoxas EngClass hook so all those pseudo hardpoints are coming up in the spew, not a problem I cant ignore but its a lot of red lines

[error][ships\shiparch.ini:32634:Ship:hp_type] Invalid hardpoint-type! elite_engine 10
[error][ships\shiparch.ini:32635:Ship:hp_type] Invalid hardpoint-type! elite_power 10

I use
elite_power 1 - 10
fighter_power 1 -10
freighter_power 1 - 10
elite_engine 1 - 10
fighter_engine 1 -10
freighter_engine 1 - 10

M1C

sur-files aren’t referenced in the inis, are they? I think that’s the problem, use the newest version to find out where it is referenced (same link: http://forge.the-starport.net/projects/flscan2/repository/entry/bin/FLScanII.exe)
It was searching for “lighsource” fixed, ambient is fixed as well.

You can filter single messages by using the textbox next to the filter-selection.
I’ll include a feature to change the list of allowed hp-types, ship-types, etc.

Thanks!

Timmy51m

Fair play, awesome tool. I’ve been trying for months to iron out all the encounter bugs with Itano Circus, but it was like looking for a needle in a haystack once I found all the obvious ones, you’ve put an end to a massive headache guys.

Many thanks!

Thaddeus

M1C wrote:
sur-files aren’t referenced in the inis, are they?

You’re right, my bad. typo in the shiparch which your tool caught… fantastic!

M1C

Version 1.1 is out
See head-post, http://the-starport.net/freelancer/forum/viewtopic.php?topic_id=4726

? Offline

Thx M1C and Cannon!
Very useful especially command-line mode

Idea: to add –log command line switch, for example

FLScanII.exe --flpath="C:\Program Files\Freelancer" --log=result.log

M1C

Done
New options:
–log-html= <filename>Creates a colored html-log
–log-file= <filename>Creates a simple text-log
–log-console logs to the console as usual (implied when html and file isn’t set)

You can also log to a file and to the console like this:
FLScanII.exe --log-html=MyFile.html --log-console

Please use this link util I release the next version:
http://forge.the-starport.net/projects/flscan2/repository/raw/bin/FLScanII.exe</filename></filename>

? Offline

Wow! Thx M1C

All ok except html has two collumns

M1C

Where is the problem with 2 columns? I made them on purpose

? Offline

Hehe : )
Look:

FLScanII.exe --flpath="C:\Program Files\Freelancer" --log-html=result.html --log-console

Console tells:

[error][equipment\market_commodities.ini:1638:BaseGood:MarketGood] Invalid multiplier! Has to be a number! 1.003713

But html tells:

ERROR	Invalid multiplier! Has to be a number!

M1C

Oh, that’s broken
I’ll look into this, thanks!